-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Added flatpages-extra #2144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Added flatpages-extra #2144
Conversation
9973089
to
aa27de7
Compare
aa27de7
to
c54f6dc
Compare
c54f6dc
to
07ccd8d
Compare
Adding the link for easier review: https://pypi.org/project/django-flatpages-extra/ |
+1 for having the "is published" feature and revisions, but not sure about offloading both of them to a new package.
|
@bmispelon I think we may want to have CI on that package as well, otherwise upgrades could be a bit tricky in the future [if things fall out of date with new versions of Django]. |
07ccd8d
to
d82b054
Compare
The code is hosted on Codeberg where CI is not so easy to set up. I've added a I also took the liberty of rebasing this PR onto the latest Would folks be ok if I deployed this on the preview server? |
The "small custom model" is how django-flatpages-extra started. I originally created it inside the source code of this site, but realized it could be useful as a third party. I've designed the |
Thanks for the details.
That sounds okay to me. |
I've deployed this to the preview server. I'll reach out to Stephanie to see if she has time to test it to see if it this solution would work for her. |
This PR adds
django-flatpages-extra
, which is a package I created after a discussion with @StephanieAG from the fundraising WG on how to make it easier to update flat pages.As you can tell from the very short PR, the package is a drop-in replacement and is reversible. It adds the following features to the admin:
Initially I was going to develop this as an app in this project, but then realized it might be useful as a 3rd party too. If accepted I would release a 1.0 of the package.
Screenshots:
Editing content directly is disabled
Preview page
Compare view (diff)