Skip to content

Update Leaders donation limit text #2191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+2 −2
Open

Update Leaders donation limit text #2191

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f0e2e6b
fix: update text for leadership-level donors
house-ben Sep 11, 2025
2b3f790
Updated to match Heroes section of fundraising page
house-ben Sep 11, 2025
5162c72
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions djangoproject/templates/fundraising/includes/display_django_heroes.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,8 @@ <h3>{% blocktranslate trimmed with amount=display_logo_amount|intcomma %}
Leaders (${{ amount }}+){% endblocktranslate %}</h3>
<p>
{% blocktranslate trimmed with amount=display_logo_amount|intcomma %}
Leadership-level donors contribute ${{ amount }} or
more in a calendar year.
Leadership-level donors contribute at least ${{ amount }}
and have donated in the last {{ display_donor_days }} days.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if we want to have this displaying in the last 365 days. I think I'll prefer to say in the last calendar year instead.

Suggested change
and have donated in the last {{ display_donor_days }} days.
and have donated in the last calendar year.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thibaudcolas What do you think about this? Is the intention here to say 365 days explicitly?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rechecked this, and the way we calculate this is indeed for the last 365 days. So, this change looks good to me.

{% endblocktranslate %}
</p>
<div>
Expand Down