Fix footnote link accessibility in release tables (closes #2233) #2239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change 'Former Django Fellows:' from <p> to <h3> tag for proper semantic HTML structure. This improves accessibility, SEO, and visual consistency of the fundraising page.
- Add base_lite.html: Minimal base template with extensive block structure - Add flatpages/lite.html: Flatpage template with CSS/JS extraction - Add lite_filters.py: Template filters for automatic CSS/JS separation - Update settings/common.py: Add djangoproject to INSTALLED_APPS for template tags Features: - Automatic extraction of CSS to <head> and JS to end of <body> - Clean content separation for better HTML structure - Perfect for annual reports and special publications - Maintains SEO and accessibility with proper meta tags - 25+ customizable template blocks for complete flexibility Usage: Set flatpage template to 'flatpages/lite.html' and include embedded CSS/JS directly in content - template handles the rest!
Improve contrast ratios for footnote links in django-supported-versions and django-unsupported-versions tables to meet WCAG accessibility standards. - Add specific styling for table sup a elements - Use proper link colors with adequate contrast - Add hover/focus states for better UX - Fixes contrast issues in both light and dark modes Resolves poor contrast ratios: - Dark mode: 1.15:1 4.5:1+ (WCAG AA compliant) - Light mode: 2.79:1 4.5:1+ (WCAG AA compliant)
for more information, see https://pre-commit.ci
|
Hi again, Your PR seems to include multiple commits unrelated to the issue, could you fix that please? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes poor contrast ratios for footnote links in release tables, addressing accessibility concerns raised in #2233.
Problem
Footnote links in the "Future Roadmap" and release tables had extremely poor contrast ratios:
Solution
Added specific CSS rules for footnote links in tables (
table sup a) that:var(--link-color)for proper contrast in both light and dark modesCode Changes
djangoproject/scss/_style.scsstable sup aelementsTesting
Closes
Fixes #2233