Conversation
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
==========================================
- Coverage 86.55% 79.96% -6.59%
==========================================
Files 28 36 +8
Lines 476 639 +163
==========================================
+ Hits 412 511 +99
- Misses 64 128 +64 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| LOGGING = { | ||
| 'version': 1, | ||
| 'disable_existing_loggers': False, | ||
| 'handlers': { | ||
| 'console': { | ||
| 'class': 'logging.StreamHandler', | ||
| }, | ||
| }, | ||
| 'loggers': { | ||
| '': { | ||
| 'handlers': ['console'], | ||
| 'level': 'INFO', | ||
| }, | ||
| }, | ||
| } |
There was a problem hiding this comment.
It's better to move the LOGGING configuration to the appropriate environment specific settings rather than adding it to the base settings.
core/settings_dev.py
Outdated
|
|
||
| EMAIL_BACKEND = "django.core.mail.backends.filebased.EmailBackend" | ||
| # Email Sending settings | ||
| DEFAULT_FROM_EMAIL = os.environ.get("DEFAULT_FROM_EMAIL", "rakoto.olive42@gmail.com") |
There was a problem hiding this comment.
Let's leave the default email as the one used by the person setting up the site.
|
We have to use an email granted by mailjet. But yep we can change it
Sent from my mobile device,
Please excuse my brevity :)
+261327581828
GMT+3
…On Mon, 12 May 2025 at 19:32 Sal ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In core/settings_dev.py
<#73 (comment)>
:
> @@ -37,6 +37,61 @@
)
}
-EMAIL_BACKEND = "django.core.mail.backends.filebased.EmailBackend"
+# Email Sending settings
+DEFAULT_FROM_EMAIL = os.environ.get("DEFAULT_FROM_EMAIL", ***@***.***")
Let's leave the default email as the one used by the person setting up the
site.
—
Reply to this email directly, view it on GitHub
<#73 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAE7GWJOBVIBRM6W7MD3BMT26DEK5AVCNFSM6AAAAAB4R53JUCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQMZTHAZTSMRUGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
website/header_menu_items.py
Outdated
| children=[ | ||
| HeaderLink(label=_("News"), href="/news"), | ||
| HeaderLink(label=_("Opportunity Grants"), href="/opportunity_grants"), | ||
| HeaderLink(label=_("Status Grants"), href="/grants/request_code/"), |
There was a problem hiding this comment.
Grant Status is commonly used instead of Status Grant
theShinigami
left a comment
theShinigami
left a comment
There was a problem hiding this comment.
Thank you for all your work!, a few little final tweaks 🙂
3 participants
This is a PR for checking status grant for speakers or attendees. Users can enter their email in a form. A random code will be sent to the address email (via Mailjet) for more safety.