Skip to content

bb8-redis: document caveat of redis connection config #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nigimaxx wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −0
Open

bb8-redis: document caveat of redis connection config #276

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions redis/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
//! Redis support for the `bb8` connection pool.
//!
//! _Due to the default connection config, pooled connections have a response timeout and can't be used for blocking commands._ \
//! _See [`get_multiplexed_async_connection`](redis::Client::get_multiplexed_async_connection) and [`AsyncConnectionConfig`](redis::AsyncConnectionConfig) for more details._
Comment on lines +3 to +4
Copy link
Owner

@djc djc Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I think I finally understand what the issue is that you're talking about. So did they change this in a recent release?

I guess my beef with this is that it seems in no way to specific to connection pooling, so I don't see why we should document it.

//!
//!
//! # Example
//!
//! ```
Expand Down