Skip to content

[WIP] Replace progress APIs in favor of elapsed APIs #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 27 commits into from
Closed

[WIP] Replace progress APIs in favor of elapsed APIs #38

wants to merge 27 commits into from

Conversation

@SUPERCILEX
Copy link
Contributor

@SUPERCILEX SUPERCILEX commented Aug 3, 2022 •
edited
Loading

Fixes #42, fixes #31.

SUPERCILEX added 17 commits May 29, 2022 22:10
@SUPERCILEX
Move towards more flexible animation looping
9288b0f 
Signed-off-by: Alex Saveau <[email protected]>
@SUPERCILEX
Don't use nightly stuff
30b077a 
Signed-off-by: Alex Saveau <[email protected]>
@SUPERCILEX
Merge remote-tracking branch 'upstream/main' into loop
c01b3ea 
# Conflicts:
#	src/lib.rs
#	src/tweenable.rs
@SUPERCILEX
Get rid of is_looping and finish implementing stuff
3df8870 
Signed-off-by: Alex Saveau <[email protected]>
@SUPERCILEX
Reformat all comments using rustfmt
4e15064 
Signed-off-by: Alex Saveau <[email protected]>
@SUPERCILEX
Merge branch 'comments' into loop
31ef21f 
Signed-off-by: Alex Saveau <[email protected]>

# Conflicts:
#	examples/sequence.rs
#	src/lib.rs
#	src/tweenable.rs
@SUPERCILEX
Final cleanup
178db98 
Signed-off-by: Alex Saveau <[email protected]>
@SUPERCILEX
Merge remote-tracking branch 'upstream/main' into loop
351c180 
# Conflicts:
#	examples/sequence.rs
#	src/lib.rs
#	src/tweenable.rs
@SUPERCILEX
Tidy
e119f73 
Signed-off-by: Alex Saveau <[email protected]>
@SUPERCILEX
Use repeat and mirrored repeat terminology
2f96f06 
Signed-off-by: Alex Saveau <[email protected]>
@SUPERCILEX
Scootch duration to a place that makes more sense
90bd931 
Signed-off-by: Alex Saveau <[email protected]>
@SUPERCILEX
Merge remote-tracking branch 'upstream/main' into loop
7e2aac1 
# Conflicts:
#	examples/sequence.rs
#	src/tweenable.rs
@SUPERCILEX
Start implementing plan
af67aaa 
Signed-off-by: Alex Saveau <[email protected]>
@SUPERCILEX
Fix very odd failure that doesn't occur on nightly
74a79cc 
Signed-off-by: Alex Saveau <[email protected]>
@SUPERCILEX
Remove debug statement
595c2f9 
Signed-off-by: Alex Saveau <[email protected]>
@SUPERCILEX
Address feedback
035c8cc 
Signed-off-by: Alex Saveau <[email protected]>
@SUPERCILEX
Progress
ed9b383 
Signed-off-by: Alex Saveau <[email protected]>
@djeedai djeedai mentioned this pull request Aug 3, 2022
Merged
@djeedai djeedai added the enhancement New feature or request label Aug 3, 2022
This was referenced Aug 4, 2022
Closed
Closed
@SUPERCILEX
Merge remote-tracking branch 'upstream/main' into elapsed
d3f208d 
# Conflicts:
#	src/lib.rs
#	src/tweenable.rs
@SUPERCILEX
Add back bad merge stuff
d098f83 
Signed-off-by: Alex Saveau <[email protected]>
@SUPERCILEX
Fix broken code
2212592 
Signed-off-by: Alex Saveau <[email protected]>
@SUPERCILEX
Progress
cf7bdb9 
Signed-off-by: Alex Saveau <[email protected]>
@SUPERCILEX
Blah
5691216 
Signed-off-by: Alex Saveau <[email protected]>
@SUPERCILEX
Copy link
Contributor Author

SUPERCILEX commented Aug 4, 2022

@djeedai this needs #37 (and #44 if that goes through) to be done right. Once I have the new testing framework I'll wrap up the sequence elapsed implementation.

@SUPERCILEX
Finish implementation
96cab31 
Signed-off-by: Alex Saveau <[email protected]>
@SUPERCILEX
Copy link
Contributor Author

SUPERCILEX commented Aug 6, 2022

@djeedai this should be ready to go implementation wise! I'm waiting on #37 to write proper tests (which is waiting on the reverted commits being restored).

@djeedai
Copy link
Owner

djeedai commented Aug 6, 2022

Re-reverted, all commits are back :)

@SUPERCILEX
Copy link
Contributor Author

SUPERCILEX commented Aug 6, 2022

Sweet! I updated #37 and #44.

@SUPERCILEX SUPERCILEX mentioned this pull request Aug 10, 2022
Open
@SUPERCILEX SUPERCILEX mentioned this pull request Sep 20, 2022
Open
@djeedai
Copy link
Owner

djeedai commented Oct 21, 2025

Closing as Obsolete, this has been fixed.

@djeedai djeedai closed this Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Repeat broken after first iteration Get rid of progress and times_completed (well keep an ext trait with it around) in favor of elapsed

2 participants

@SUPERCILEX @djeedai