Fix kwargs replacement bug in template function formatting#1356
Draft
Fix kwargs replacement bug in template function formatting#1356
Conversation
❌ Deploy Preview for djlint failed.
|
…data Co-authored-by: monosans <76561516+monosans@users.noreply.github.com>
Co-authored-by: monosans <76561516+monosans@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [BUG] [Formatter] Replaces kwargs with empty {}
Fix kwargs replacement bug in template function formatting
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The formatter was potentially replacing
**kwargssyntax with{}in Jinja2 template function calls due to unsafe evaluation of function parameters.Problem
When formatting templates like:
The
**kwargscould be replaced with{}, breaking the template functionality.Root Cause
The
format_datafunction insrc/djlint/formatter/indent.pyattempts to evaluate template function parameters usingeval()as a fallback when JSON parsing fails. While**kwargssyntax normally fails eval and should preserve the original content, there were edge cases where this could interfere with Python unpacking syntax.Solution
Added a defensive check to prevent
eval()from being called on any content containing**syntax:This ensures that
**kwargs,**data, and any other Python unpacking syntax is always preserved in template function calls.Changes
format_datafunction to skip evaluation for content containing**syntax**kwargsscenarios**syntaxThe fix is minimal and surgical - it only affects the specific eval logic path that could cause issues, while maintaining all other formatter functionality.
Fixes #1030.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.