Fix ignore_blocks with non-zero indentation#1525
Open
tdryer wants to merge 1 commit intodjlint:masterfrom
Open
Fix ignore_blocks with non-zero indentation#1525tdryer wants to merge 1 commit intodjlint:masterfrom
ignore_blocks with non-zero indentation#1525tdryer wants to merge 1 commit intodjlint:masterfrom
Conversation
The `ignore_blocks` option skips indentation of content inside ignored
template block tags. This works by skipping indentation when a block
begins. However, it does not skip un-indentation when a block ends,
causing unexpected results when a block has a non-zero indentation
level.
Expected:
<p>
{% raw %}
test
{% endraw %}
</p>
Actual:
<p>
{% raw %}
test
{% endraw %}
</p>
Fix this by modifying the `template_unindent` pattern to exclude tags
that are in `ignore_blocks` via a negative lookahead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ignore_blocksoption skips indentation of content inside ignored template block tags. This works by skipping indentation when a block begins. However, it does not skip un-indentation when a block ends, causing unexpected results when a block has a non-zero indentation level.Expected:
Actual:
Fix this by modifying the
template_unindentpattern to exclude tags that are inignore_blocksvia a negative lookahead.