Allow configuration of the webserver_service#243
Open
cswingler wants to merge 1 commit intodjoos-cookbooks:masterfrom
Open
Allow configuration of the webserver_service#243cswingler wants to merge 1 commit intodjoos-cookbooks:masterfrom
cswingler wants to merge 1 commit intodjoos-cookbooks:masterfrom
Conversation
Author
|
I hate to be that guy, but can I get a review on this? This ended up being a blocker for a project I put back on the shelf for a while that we might be taking down in the near future. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes some assumptions on how the webserver_service is handled. In particular, I hit up against this case when using php5-fpm on Ubuntu 14.04 - I needed to be able to drop the "reload" action (it's not supported) as well as switch to using Upstart.