Open
Conversation
Author
|
Resolves Issue #359 |
Member
|
Hi @ChNorman, thanks for this PR - is there any chance to rebase the PR so it only includes the New Relic .Net Core Agent changes? It seems other changes are included as well currently... Thanks in advance! |
Author
|
hi @djoos I could attempt to but outside of the changes for the .net core the only other thing in the pull request was changes required to fet integrated testing to pass and to get the request to pass your CI build |
Author
|
hi @djoos I rebased as requested but it looks like some current rubocop rules are causing CI integration to fail. Please let me know how you would like to address because some of the failures are out side code that I modified |
Changes to be committed: modified: .kitchen.yml modified: attributes/repository.rb modified: libraries/helpers.rb modified: libraries/matchers.rb modified: metadata.rb modified: providers/agent_dotnet.rb new file: providers/agent_dotnetcore.rb modified: recipes/default.rb new file: recipes/dotnetcore_agent.rb new file: resources/agent_dotnetcore.rb modified: spec/unit/agent_dotnet_spec.rb new file: spec/unit/agent_dotnetcore_spec.rb modified: spec/unit/agent_php_spec.rb modified: spec/unit/default_spec.rb modified: spec/unit/repository_spec.rb new file: test/fixtures/cookbooks/newrelic_lwrp_test/recipes/agent_dotnetcore.rb modified: test/fixtures/cookbooks/newrelic_lwrp_test/recipes/agent_php.rb new file: test/integration/dotnetcore-agent/serverspec/default_spec.rb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updated with lwrp to install New Relic .Net Core Agent