Open
Conversation
…roller * Changed the behavior of usesDrawViewHierarchyInRect option in FBSnapshotTestController
djrtl
reviewed
Oct 30, 2017
| [view drawViewHierarchyInRect:view.bounds afterScreenUpdates:YES]; | ||
|
|
||
| if (drawingViewHierarchyInRect) { | ||
| [view drawViewHierarchyInRect:view.bounds afterScreenUpdates:YES]; |
djrtl
reviewed
Oct 30, 2017
|
|
||
| /** | ||
| When YES, adds view to a window before capturing the snapshot. | ||
| @attention Can't be used with layers. |
Owner
There was a problem hiding this comment.
a better semantics here would be "the setting only affects views, and ignored for layers", or "for layers this must be left to NO".
djrtl
reviewed
Oct 30, 2017
| /** | ||
| When YES, adds view to a window before capturing the snapshot. | ||
| @attention Can't be used with layers. | ||
| @attention If the view does't belong to a UIWindow, it will create one and add the view as a subview. |
djrtl
reviewed
Oct 30, 2017
| */ | ||
| @property (readwrite, nonatomic, assign) BOOL usesDrawViewHierarchyInRect; | ||
|
|
||
| /** |
Owner
There was a problem hiding this comment.
Missing the period at the end (also for usesDrawViewHierarchyInRect above), and more importantly the description of what happens if the flag is NO (which I assume is the default).
…sWindowToDrawViewHierarchy options
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added usesWindowToDrawViewHierarchy option is to FBSnapshotTestController and FBSnapshotTestCase
Changed the behavior of usesDrawViewHierarchyInRect option in FBSnapshotTestController