Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds a GORM index on the task_id column of the task_histories table to improve lookup performance.
- Updated the
TaskHistory.TaskIDfield tag to includeindex:idx_task_histories_task_id
Comments suppressed due to low confidence (1)
internal/models/task.go:27
- Consider adding a corresponding database migration script to create the
idx_task_histories_task_idindex on thetask_historiestable, as updating the GORM tag alone won't apply the index to existing databases.
TaskID int `json:"task_id" gorm:"column:task_id;not null;index:idx_task_histories_task_id"`
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
dkhalife
added a commit
that referenced
this pull request
Oct 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
task_histories.task_idwith friendly nameidx_task_histories_task_idTesting
go test ./...https://chatgpt.com/codex/tasks/task_e_686b6259943c832abef7086632ea346b