Skip to content

Conversation

@dkhalife
Copy link
Owner

No description provided.

Copilot AI review requested due to automatic review settings December 14, 2025 23:31
@dkhalife dkhalife enabled auto-merge (squash) December 14, 2025 23:33
@dkhalife dkhalife merged commit 836dec0 into main Dec 14, 2025
13 checks passed
@dkhalife dkhalife deleted the protobuf branch December 14, 2025 23:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds Protocol Buffer definitions and generated code to enable gRPC communication between the frontend and backend. It includes protobuf schema definitions for tasks, users, labels, and common types, along with generation scripts for TypeScript (frontend) and Go (backend) code.

Key Changes:

  • Added 5 protobuf schema files defining data models and gRPC services
  • Generated TypeScript code for frontend gRPC communication (~5,000 lines)
  • Generated Go code for backend gRPC services (~1,200 lines)
  • Added PowerShell scripts to automate code generation
  • Updated dependencies in both frontend and backend

Reviewed changes

Copilot reviewed 22 out of 25 changed files in this pull request and generated no comments.

Show a summary per file
File Description
proto/*.proto Protobuf schema definitions for common types, users, tasks, labels, and service definitions
proto/generate*.ps1 PowerShell scripts to generate TypeScript and Go code from proto files
frontend/src/grpc/*.ts Generated TypeScript code for gRPC client communication (auto-generated)
apiserver/internal/grpc/*.pb.go Generated Go code for gRPC server implementation (auto-generated)
frontend/package.json Added grpc-web, @bufbuild/protobuf, and ts-proto dependencies
frontend/eslint.config.js Updated to ignore generated grpc files from linting
frontend/yarn.lock Lock file updates for new frontend dependencies
apiserver/go.mod Added google.golang.org/grpc and updated protobuf version

The PR appears well-structured with proper separation of schema definitions and generated code. All generated files include appropriate "DO NOT EDIT" headers. The changes follow protobuf best practices with properly namespaced packages and consistent naming conventions.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Dec 14, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants