Skip to content

Conversation

@ntrel
Copy link
Contributor

@ntrel ntrel commented Dec 20, 2025

Note: switch added in #22248.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#22275"

@ntrel ntrel marked this pull request as ready for review December 20, 2025 13:15
@ntrel
Copy link
Contributor Author

ntrel commented Jan 24, 2026

Build failing because #22244 was merged.

Also probably only some of the CI jobs should use the edition switch. Perhaps only the ones that run the style check.

@ntrel ntrel marked this pull request as draft January 25, 2026 20:52
@ntrel
Copy link
Contributor Author

ntrel commented Jan 25, 2026

Build failing because #22244 was merged.

I'm trying dfix with libdparse updated on druntime as it has support for fixing old alias declarations, but I found 2 bugs so far: dlang-community/dfix#62

@Herringway
Copy link
Contributor

Isn't it possible that compiling with a different edition may result in different symbols?

@ntrel
Copy link
Contributor Author

ntrel commented Jan 26, 2026

I'm trying dfix with dlang-community/dfix#61 on druntime

This is going quite well, I fixed the dfix bugs. I have to keep taking breaks reviewing the massive druntime/src/core/sys/windows/ diff though. There are a lot of aliases there 😱

@thewilsonator
Copy link
Contributor

Thank you so much for doing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants