Refactor UDA Handling: Improve Safety and Support Single Attributes #22287
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This PR refactors the User Defined Attribute (UDA) semantic analysis logic within dmd.attribsem. The primary goals are to improve compiler stability and ensure consistent attribute iteration.
Changes:
getAttributes:
Added early exit to avoid heap allocation for empty attribute blocks.
Improved recursive collection of attributes from parent declarations.
foreachUda:
Bug Fix: Added null-check for the attribute list to prevent crashes during semantic analysis.
Feature: Implemented support for single (non-tuple) attributes. Previously, standalone UDAs might have been skipped during iteration.
Cleanup: Removed redundant/unreachable code blocks and unified the iteration logic using each!.