-
-
Notifications
You must be signed in to change notification settings - Fork 668
Improve template error msg #22310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Iskaban10
wants to merge
30
commits into
dlang:master
Choose a base branch
from
Iskaban10:improve-error-msg
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Improve template error msg #22310
Changes from 13 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
0074a1f
fix #21399 - error message for multiple character constants
Iskaban10 abe147f
fix #21399 updated
Iskaban10 465079c
fail4544.d updated
Iskaban10 d44d7a7
changed fail4544.d
Iskaban10 aabadb3
Merge branch 'dlang:master' into improve-error-msg
Iskaban10 f28104c
fix #21381 for correct location in error message
Iskaban10 9953faa
Merge branch 'improve-error-msg' of https://github.com/Iskaban10/dmd …
Iskaban10 5c43e6e
Updated
Iskaban10 a705fa9
Better Template error messages
Iskaban10 39df2e2
Updated
Iskaban10 790aa66
Updated
Iskaban10 0bab93e
Updated
Iskaban10 ebb014e
Updated
Iskaban10 73de5a6
Removed fprintf
Iskaban10 3c9b4ad
Added message()
Iskaban10 7700710
Function is @safe and returns const(char)*
Iskaban10 3457709
buf.ptr replaced with &buf[0]
Iskaban10 9a3b0b5
Merge branch 'dlang:master' into improve-error-msg
Iskaban10 70f01fb
Updated fail_compilation tests
Iskaban10 2dc7f0f
Merge branch 'improve-error-msg' of https://github.com/Iskaban10/dmd …
Iskaban10 b0a9eaf
Changed \ t /
Iskaban10 500c1f6
Updated tests
Iskaban10 f8189de
Updated tests
Iskaban10 4b8ed8f
Updated tests
Iskaban10 00af04b
Updated tests
Iskaban10 64a865a
Updated tests
Iskaban10 70ea306
Updated tests
Iskaban10 2d075f0
Updated test
Iskaban10 7ed3eea
Removed Whitespaces
Iskaban10 6db2b04
Removed Whitespaces
Iskaban10 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All diagnostics have to go via the appropriate machinery, not raw printfs.
For example so that it doesn't mess up diagnostics in json or sarif format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have used the fprintf to print just the header for the diagnostic message. Passing it through error() function would require unavailable location parameters for the header message.