Implement most RVO cases in glue layer#22526
Open
limepoutine wants to merge 1 commit intodlang:masterfrom
Open
Implement most RVO cases in glue layer#22526limepoutine wants to merge 1 commit intodlang:masterfrom
limepoutine wants to merge 1 commit intodlang:masterfrom
Conversation
Contributor
|
Thanks for your pull request and interest in making D better, @limepoutine! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#22526" |
Contributor
Author
|
Is it the test runners ran out of memory twice in a row, or is it I introduced a bug? Needs investigation anyway. |
a003dd9 to
a2365d2
Compare
a2365d2 to
c53b84c
Compare
c53b84c to
de9f233
Compare
toElemRVO in line with canElideCopy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#22412, part 3
This PR enables direct construction in
ConstructExpfor any LHS and most RHS expressions, with two exceptions:v = T(S(1))doesn't emplaceS(1)(a second PR is pending)v = T(a: S(b: U(1)).a.bdoesn't fold tov = U(1)(implementing this doesn't appear to be of much benefit)Also fixes the bug that
a = b = S(1)fails to call the copy constructor ofS. Note the removed tests are fully covered by new ones.