Skip to content

fix Issue 21622 - Ambiguous template instantiation without parens crashes compiler #22550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TANAY-BARGIR wants to merge 1 commit into
base: master
Choose a base branch
from
+40 −0
Open

fix Issue 21622 - Ambiguous template instantiation without parens crashes compiler #22550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions compiler/src/dmd/sideeffect.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@

module dmd.sideeffect;

import dmd.dtemplate;
import dmd.dsymbol;
Comment on lines +14 to +15
Copy link
Contributor

@thewilsonator thewilsonator Feb 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imports should be in alphabetic order

import dmd.astenums;
import dmd.declaration;
import dmd.dscope;
Expand Down Expand Up @@ -391,6 +393,25 @@ bool discardValue(Expression e)
}
}
return !seenSideEffect;
case EXP.scope_:
{
if (auto se = e.isScopeExp())
{
if (auto ti = se.sds.isTemplateInstance())
{
if (!ti.aliasdecl && ti.tempdecl)
{
error(e.loc, "`%s` matches multiple overloads exactly", se.sds.toChars());
}
}
else if (se.sds && se.sds.isOverloadSet())
{
error(e.loc, "`%s` matches multiple overloads exactly", se.sds.toChars());
}
}
error(e.loc, "`%s` has no effect", e.toErrMsg());
return true;
}
default:
break;
}
Expand Down
19 changes: 19 additions & 0 deletions compiler/test/fail_compilation/issue21622.d
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
/*
TEST_OUTPUT:
---
issue21622.d(17): Error: `foo!0` matches multiple overloads exactly
issue21622.d(17): Error: `foo!0` has no effect
---
*/

// https://github.com/dlang/dmd/issues/21622

template foo(int N) {
void foo() {}
}

void foo(int N)() {}

void main() {
foo!0;
}
Loading