Skip to content

Fix Issue 21622: Ambiguous template without parentheses gives 'no effect' error#22803

Open
shivajigandham wants to merge 4 commits intodlang:masterfrom
shivajigandham:fix-issue-21622
Open

Fix Issue 21622: Ambiguous template without parentheses gives 'no effect' error#22803
shivajigandham wants to merge 4 commits intodlang:masterfrom
shivajigandham:fix-issue-21622

Conversation

@shivajigandham
Copy link
Copy Markdown

Fixes #21622

Description

When an ambiguous template function is instantiated without parentheses (e.g. \ oo!0;), the compiler previously reported a generic and confusing \has no effect\ error because the expression returned a valid but ambiguous \TemplateInstance\ or \OverExp\ which was then passed to \discardValue().

This PR updates \discardValue()\ in \sideeffect.d\ to explicitly check for \EXP.overloadSet\ and \EXP.scope_\ (when it points to an ambiguous \TemplateInstance/\OverloadSet) and reports a \matches multiple overloads\ error instead, matching the behavior of parenthesized calls.

@dlang-bot
Copy link
Copy Markdown
Contributor

Thanks for your pull request and interest in making D better, @shivajigandham! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

  • In preparation for migrating from Bugzilla to GitHub Issues, the issue reference syntax has changed. Please add the word "Bugzilla" to issue references. For example, Fix Bugzilla Issue 12345 or Fix Bugzilla 12345.(Reminder: the edit needs to be done in the Git commit message, not the GitHub pull request.)

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#22803"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ambiguous template function instantiation without parentheses gives a strange "no effect" error

2 participants