-
-
Notifications
You must be signed in to change notification settings - Fork 238
Rename PackageName.main to .base to making naming consistent #3084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: stable
Are you sure you want to change the base?
Conversation
|
✅ PR OK, no changes in deprecations or warnings Total deprecations: 0 Total warnings: 0 Build statistics: statistics (-before, +after)
executable size=5265688 bin/dub
rough build time=56sFull build output |
792ee2a to
58c8cce
Compare
|
Some tests failure because I guess I should merge dlang-community/setup-dlang#94 since it's been staying there all this time, then you could do: - name: Install latest DMD
uses: dlang-community/setup-dlang@v2
with:
dc_format: basenameand the test should pass. Alternatively, making it less flasky is also a good idea: https://github.com/the-horo/dub/blob/ba66cf37fd8597fa830805872d169be1a957150d/test/new_tests/issue2012-dc-env/sample/app.d |
This is and has always been referred to "base package name" throughout the code base and should be named like this here, too, to avoid confusion.
Also reduces the amount of explicit attribute annotations a bit.