fix: auto-create workingDirectory before running executable#3097
Merged
thewilsonator merged 2 commits intodlang:masterfrom Mar 8, 2026
Merged
fix: auto-create workingDirectory before running executable#3097thewilsonator merged 2 commits intodlang:masterfrom
thewilsonator merged 2 commits intodlang:masterfrom
Conversation
|
✅ PR OK, no changes in deprecations or warnings Total deprecations: 0 Total warnings: 0 Build statistics: statistics (-before, +after)
executable size=5710288 bin/dub
-rough build time=67s
+rough build time=68sFull build output |
thewilsonator
approved these changes
Mar 6, 2026
Contributor
thewilsonator
left a comment
There was a problem hiding this comment.
Otherwise looks good
Contributor
|
Also, is it possible to add a test case for this? (It early and I'm still waking up and am having trouble parsing the description on the original issue). |
ff84f3d to
3740107
Compare
Create the workingDirectory if it does not exist before spawning the target process. This prevents `dub run` from failing when the workingDirectory has not been created yet. Fixes dlang#3082
3740107 to
482bd95
Compare
Contributor
Author
|
i added test, please check |
thewilsonator
approved these changes
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create the workingDirectory if it does not exist
before spawning the target process.
This prevents
dub runfrom failing when theworkingDirectory has not been created yet.
Fixes #3082