Skip to content

fix: auto-create workingDirectory before running executable#3097

Merged
thewilsonator merged 2 commits intodlang:masterfrom
kmr-ankitt:fix/workingdir-autocreate
Mar 8, 2026
Merged

fix: auto-create workingDirectory before running executable#3097
thewilsonator merged 2 commits intodlang:masterfrom
kmr-ankitt:fix/workingdir-autocreate

Conversation

@kmr-ankitt
Copy link
Contributor

Create the workingDirectory if it does not exist
before spawning the target process.

This prevents dub run from failing when the
workingDirectory has not been created yet.

Fixes #3082

@github-actions
Copy link

github-actions bot commented Mar 4, 2026

✅ PR OK, no changes in deprecations or warnings

Total deprecations: 0

Total warnings: 0

Build statistics:

 statistics (-before, +after)
 executable size=5710288 bin/dub
-rough build time=67s
+rough build time=68s
Full build output
DUB version 1.41.0, built on Mar  1 2026
LDC - the LLVM D compiler (1.42.0):
  based on DMD v2.112.1 and LLVM 21.1.8
  built with LDC - the LLVM D compiler (1.42.0)
  Default target: x86_64-unknown-linux-gnu
  Host CPU: znver3
  https://dlang.org - https://wiki.dlang.org/LDC


  Registered Targets:
    aarch64     - AArch64 (little endian)
    aarch64_32  - AArch64 (little endian ILP32)
    aarch64_be  - AArch64 (big endian)
    amdgcn      - AMD GCN GPUs
    arm         - ARM
    arm64       - ARM64 (little endian)
    arm64_32    - ARM64 (little endian ILP32)
    armeb       - ARM (big endian)
    avr         - Atmel AVR Microcontroller
    bpf         - BPF (host endian)
    bpfeb       - BPF (big endian)
    bpfel       - BPF (little endian)
    hexagon     - Hexagon
    lanai       - Lanai
    loongarch32 - 32-bit LoongArch
    loongarch64 - 64-bit LoongArch
    mips        - MIPS (32-bit big endian)
    mips64      - MIPS (64-bit big endian)
    mips64el    - MIPS (64-bit little endian)
    mipsel      - MIPS (32-bit little endian)
    msp430      - MSP430 [experimental]
    nvptx       - NVIDIA PTX 32-bit
    nvptx64     - NVIDIA PTX 64-bit
    ppc32       - PowerPC 32
    ppc32le     - PowerPC 32 LE
    ppc64       - PowerPC 64
    ppc64le     - PowerPC 64 LE
    r600        - AMD GPUs HD2XXX-HD6XXX
    riscv32     - 32-bit RISC-V
    riscv64     - 64-bit RISC-V
    sparc       - Sparc
    sparcel     - Sparc LE
    sparcv9     - Sparc V9
    spirv       - SPIR-V Logical
    spirv32     - SPIR-V 32-bit
    spirv64     - SPIR-V 64-bit
    systemz     - SystemZ
    thumb       - Thumb
    thumbeb     - Thumb (big endian)
    ve          - VE
    wasm32      - WebAssembly 32-bit
    wasm64      - WebAssembly 64-bit
    x86         - 32-bit X86: Pentium-Pro and above
    x86-64      - 64-bit X86: EM64T and AMD64
    xcore       - XCore
    xtensa      - Xtensa 32
   Upgrading project in /home/runner/work/dub/dub/
    Starting Performing "release" build using /opt/hostedtoolcache/dc/ldc2-1.42.0/x64/ldc2-1.42.0-linux-x86_64/bin/ldc2 for x86_64.
    Building dub 1.41.0+commit.15.g52656655: building configuration [application]
     Linking dub
STAT:statistics (-before, +after)
STAT:executable size=5710288 bin/dub
STAT:rough build time=68s

Copy link
Contributor

@thewilsonator thewilsonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good

@thewilsonator
Copy link
Contributor

Also, is it possible to add a test case for this? (It early and I'm still waking up and am having trouble parsing the description on the original issue).

@kmr-ankitt kmr-ankitt force-pushed the fix/workingdir-autocreate branch from ff84f3d to 3740107 Compare March 7, 2026 05:10
Create the workingDirectory if it does not exist
before spawning the target process.

This prevents `dub run` from failing when the
workingDirectory has not been created yet.

Fixes dlang#3082
@kmr-ankitt kmr-ankitt force-pushed the fix/workingdir-autocreate branch from 3740107 to 482bd95 Compare March 7, 2026 05:18
@kmr-ankitt
Copy link
Contributor Author

i added test, please check

@thewilsonator thewilsonator merged commit 4b75aea into dlang:master Mar 8, 2026
25 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dub run should create workingDirectory if it doesn't already exist

2 participants