Skip to content

Comments

Add low-overhead FixedAppender (internal for now)#10584

Closed
Oanaa28 wants to merge 1 commit intodlang:masterfrom
Oanaa28:new_feature
Closed

Add low-overhead FixedAppender (internal for now)#10584
Oanaa28 wants to merge 1 commit intodlang:masterfrom
Oanaa28:new_feature

Conversation

@Oanaa28
Copy link

@Oanaa28 Oanaa28 commented Dec 12, 2024

My PR revives the original PR (#8789).

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @Oanaa28! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#10584"

@Oanaa28 Oanaa28 force-pushed the new_feature branch 2 times, most recently from 6e4ed53 to e0a75c3 Compare December 13, 2024 16:34
@Oanaa28 Oanaa28 force-pushed the new_feature branch 5 times, most recently from 53172fb to f75869f Compare December 13, 2024 17:31
@0xEAB
Copy link
Member

0xEAB commented Jan 19, 2025

Replaced and obsoleted by the updated version of #8789 (merged as bea3184).

@0xEAB 0xEAB closed this Jan 19, 2025
@0xEAB
Copy link
Member

0xEAB commented Jan 19, 2025

Thanks for the attempt, though :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants