Skip to content

Comments

unittest: Don't run x87 log2 test on 64-bit real targets#10627

Merged
ibuclaw merged 1 commit intodlang:masterfrom
ibuclaw:fix_64bit_real
Jan 19, 2025
Merged

unittest: Don't run x87 log2 test on 64-bit real targets#10627
ibuclaw merged 1 commit intodlang:masterfrom
ibuclaw:fix_64bit_real

Conversation

@ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented Jan 19, 2025

3.05e2312L is an unrepresentable number on targets where real.mant_dig == double.mant_dig, so the test ends up requesting the result of log2(real.infinity).

Best viewed with hide whitespace.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @ibuclaw!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#10627"

@ibuclaw ibuclaw merged commit 7be45e8 into dlang:master Jan 19, 2025
9 checks passed
@ibuclaw ibuclaw deleted the fix_64bit_real branch January 19, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants