Skip to content

Comments

sumtype: fix canMatch for non-copyable ref return#10648

Merged
thewilsonator merged 1 commit intodlang:masterfrom
pbackus:fix-gh-10647
Feb 23, 2025
Merged

sumtype: fix canMatch for non-copyable ref return#10648
thewilsonator merged 1 commit intodlang:masterfrom
pbackus:fix-gh-10647

Conversation

@pbackus
Copy link
Contributor

@pbackus pbackus commented Feb 23, 2025

Handlers that return a non-copyable value by reference are now capable of successfully matching.

Fixes #10647

Handlers that return a non-copyable value by reference are now capable
of successfully matching.

Fixes dlang#10647
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @pbackus! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

  • In preparation for migrating from Bugzilla to GitHub Issues, the issue reference syntax has changed. Please add the word "Bugzilla" to issue references. For example, Fix Bugzilla Issue 12345 or Fix Bugzilla 12345.(Reminder: the edit needs to be done in the Git commit message, not the GitHub pull request.)

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#10648"

@thewilsonator thewilsonator merged commit 40daf61 into dlang:master Feb 23, 2025
10 checks passed
pbackus added a commit to pbackus/sumtype that referenced this pull request Mar 4, 2025
Frontend requirement is bumped to 2.101 for access to auto ref lambdas.

Phobos PR: dlang/phobos#10648
pbackus added a commit to pbackus/sumtype that referenced this pull request Mar 4, 2025
Frontend requirement is bumped to 2.101 for access to auto ref lambdas.

Phobos PR: dlang/phobos#10648
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sumtype: canMatch fails with handler that returns non-copyable type by ref

4 participants