Fix #10607 - Structs lines and ByLineCopy cannot be usefully constructed in @safe code#9035
Merged
thewilsonator merged 1 commit intodlang:masterfrom Jan 1, 2025
Merged
Conversation
Contributor
|
Thanks for your pull request, @schveiguy! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.
|
Member
Author
|
Replaces #9034 |
thewilsonator
approved these changes
Jul 29, 2024
Member
Author
|
I'm completely confused on the style problem. What style thing is wrong? |
Contributor
|
That is unrelated |
Contributor
|
@schveiguy can you complete the Bug Report and Test cases? Will merge once those are in. The style failures appear spurious. |
0xEAB
added a commit
to 0xEAB/phobos
that referenced
this pull request
Jan 1, 2025
0xEAB
changed the title
lines and ByLineCopy cannot be usefully constructed in @safe code
Member
|
Looks like the macOS GHA got stuck once again :/ |
… constructed in `@safe` code Originally known as "Properly mark lines constructor". Co-authored-by: Elias Batek <15967408+0xEAB@users.noreply.github.com>
thewilsonator
approved these changes
Jan 1, 2025
Member
Author
|
Ah, thanks @0xEAB I had this tab open and was planning on getting to it. Sorry. |
Member
|
No worries, you’re welcome :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still need
I just first want to see that it doesn't break anything.