-
Notifications
You must be signed in to change notification settings - Fork 456
transformations - updates #2718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 50 commits
Commits
Show all changes
62 commits
Select commit
Hold shift + click to select a range
825610c
rename flag for executing raw queries to "execute_raw_query"
sh-rp c149269
return sge queries from the internal _query method which removes a lo…
sh-rp 70116a6
adds some tests to readable dataset and a test for column hint merging
sh-rp 51a91ca
allows any dialect when writing queries and fixes tests
sh-rp 20405f1
update docs and set correct quoting to queries in normalization and l…
sh-rp c428342
fixes normalizer tests
sh-rp ec985e4
fix limit on mssql
sh-rp f153a9b
add missing quote to alias
sh-rp 1238ce0
revert identifier normalization step in normalizer_query and use bigq…
sh-rp e58ceab
post rebase fix
sh-rp 4af4ef3
smallish pr fixes
sh-rp 1a54a4c
add materializable sqlmodel and handle hints in extractor
sh-rp 7fc4753
add and test always_materialize setting
sh-rp d8c30a1
add test for sql transformation type
sh-rp de3d7f0
convert transformation functions to need yield instead of return
sh-rp 30f230d
migrate tests and docs snippets to yield in transformations
sh-rp f065066
add simple test for materializable model
sh-rp d33f198
use correct compiler for converting ibis into sqlglot for each dialect
sh-rp 8aa9d7b
add first simple version of using unbound ibis tables in transformations
sh-rp f6a7b10
skip ibis test on python 3.9
sh-rp 6a77610
Merge branch 'devel' into feat/transformations-more-decoupling
sh-rp fbd6c2b
fix query building in new relation
sh-rp 1479d5b
return a "real" relation from a transformation
sh-rp 77330c2
add ibis option when getting table from dataset
sh-rp af42236
update model item format tests to use relation
sh-rp a6cabe6
* remove one unneeded test (same thing is already tested in transform…
sh-rp 166d446
adds support for adding resource hints to pyarrow items
sh-rp 4c720da
switch most read access tests to default dataset
sh-rp d4d3285
update datasets and transformations docs pages
sh-rp f6acbb3
separate ibis and default dbapi datasets and fix typing
sh-rp de1fdf3
update transformation tests and small typing fixes for updated datasets
sh-rp 5bc6470
fix default dataset type
sh-rp 2881db0
fix wei sqlglot conversion
sh-rp fb983e3
add sqlglot dialect type and some cleanup
sh-rp 9a5f1b0
fix dataset snippets
sh-rp 4578eb9
fix sqlglot schema test
sh-rp fde9bd5
removes ibis relation and dataset
sh-rp 34a8eac
fix one doc snippet
sh-rp 9345476
rename dataset and relation interfaces
sh-rp cea5cb9
fix relation ship between cursor and relation, remove function wiring…
sh-rp a7b550b
clean up readablerelation (no actual code changes)
sh-rp 9872119
fix str test to assume pretty sql (which it is now)
sh-rp 3d6112e
small changes from review comments:
sh-rp 6bc1f20
rename query method to "to_sql" on relation
sh-rp d08aa96
clean up transform function a bit (could maybe be even better=
sh-rp 540e395
add support for "non-generator" transformations
sh-rp 7b9e8df
move hints computation into resource class
sh-rp 41e1239
smallish PR fixes
sh-rp 57e09fd
add support for dynamic hints in transformations
sh-rp 0eccfdd
fixes dynamic table caching
rudolfix a141170
Enhances ReadableDBAPIRelation: min/max, filter with expression (#2833)
anuunchin 15b4a43
Merge branch 'devel' into feat/transformations-more-decoupling
sh-rp 3b46e8a
prevent sqglot schema from adding default hints info, only allow para…
sh-rp 5b906ad
make multi schema transformations work again
sh-rp 44ae438
move model item format tests to transformations folder
sh-rp 089f5ec
re-order interface tests and fix playground dataset access
sh-rp b06d715
PR review test updated
sh-rp c5f9b33
update dataset and transformation pages
sh-rp b6577fd
Merge branch 'devel' into feat/transformations-more-decoupling
sh-rp 63dfa5f
update transformations tests to new fruitshop
sh-rp 83372df
Last PR fixes
sh-rp bd4cfd7
update columns_schema property
sh-rp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it possible to not have
query_dialect?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What we can do is to always save all queries in the duckdb dialect for example and transpile them to the right dialect before execution. This was actually the original implementation but by your request we are now saving the queries in the dialect of the dataset they where created on. Or do you just want to get rid of this method? Anyway, either way is fine by me, let me know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my question was: can
item.query_dialect()NOT return a dialect in current impl? so we can remove expression after "or"