Skip to content

fix(ios): prevent crash when FlutterEngine is destroyed during background #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IsmailAshour wants to merge 1 commit into
base: master
Choose a base branch
from
+22 −6
Open

fix(ios): prevent crash when FlutterEngine is destroyed during background #625

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 22 additions & 6 deletions ios/Classes/SwiftFlutterTtsPlugin.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,21 @@ public class SwiftFlutterTtsPlugin: NSObject, FlutterPlugin, AVSpeechSynthesizer


var channel = FlutterMethodChannel()
private var isEngineAttached = true

private func safeInvokeMethod(_ method: String, arguments: Any?) {
guard isEngineAttached else { return }
self.channel.invokeMethod(method, arguments: arguments)
}

deinit {
synthesizer.stopSpeaking(at: .immediate)
synthesizer.delegate = nil
speakResult = nil
synthResult = nil
isEngineAttached = false
}

init(channel: FlutterMethodChannel) {
super.init()
self.channel = channel
Expand Down Expand Up @@ -431,6 +446,7 @@ public class SwiftFlutterTtsPlugin: NSObject, FlutterPlugin, AVSpeechSynthesizer
}

public func speechSynthesizer(_ synthesizer: AVSpeechSynthesizer, didFinish utterance: AVSpeechUtterance) {
guard isEngineAttached else { return }
if shouldDeactivateAndNotifyOthers(audioSession) && self.autoStopSharedSession {
do {
try audioSession.setActive(false, options: .notifyOthersOnDeactivation)
Expand All @@ -446,23 +462,23 @@ public class SwiftFlutterTtsPlugin: NSObject, FlutterPlugin, AVSpeechSynthesizer
self.synthResult!(1)
self.synthResult = nil
}
self.channel.invokeMethod("speak.onComplete", arguments: nil)
self.safeInvokeMethod("speak.onComplete", arguments: nil)
}

public func speechSynthesizer(_ synthesizer: AVSpeechSynthesizer, didStart utterance: AVSpeechUtterance) {
self.channel.invokeMethod("speak.onStart", arguments: nil)
self.safeInvokeMethod("speak.onStart", arguments: nil)
}

public func speechSynthesizer(_ synthesizer: AVSpeechSynthesizer, didPause utterance: AVSpeechUtterance) {
self.channel.invokeMethod("speak.onPause", arguments: nil)
self.safeInvokeMethod("speak.onPause", arguments: nil)
}

public func speechSynthesizer(_ synthesizer: AVSpeechSynthesizer, didContinue utterance: AVSpeechUtterance) {
self.channel.invokeMethod("speak.onContinue", arguments: nil)
self.safeInvokeMethod("speak.onContinue", arguments: nil)
}

public func speechSynthesizer(_ synthesizer: AVSpeechSynthesizer, didCancel utterance: AVSpeechUtterance) {
self.channel.invokeMethod("speak.onCancel", arguments: nil)
self.safeInvokeMethod("speak.onCancel", arguments: nil)
}

public func speechSynthesizer(_ synthesizer: AVSpeechSynthesizer, willSpeakRangeOfSpeechString characterRange: NSRange, utterance: AVSpeechUtterance) {
Expand All @@ -473,7 +489,7 @@ public class SwiftFlutterTtsPlugin: NSObject, FlutterPlugin, AVSpeechSynthesizer
"end": String(characterRange.location + characterRange.length),
"word": nsWord.substring(with: characterRange)
]
self.channel.invokeMethod("speak.onProgress", arguments: data)
self.safeInvokeMethod("speak.onProgress", arguments: data)
}

}
Expand Down