dm vdo: use a short static string for thread name prefix #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
private testing running
private testing failed
and removed
private testing running
labels
Also remove MODULE_NAME, which is now unused.
This fixes a warning about string truncation in snprintf that
will never happen in practice:
drivers/md/dm-vdo/vdo.c: In function ‘vdo_make’:
drivers/md/dm-vdo/vdo.c:564:5: error: ‘%s’ directive output may be truncated writing up to 55 bytes into a region of size 16 [-Werror=format-truncation=]
"%s%u", MODULE_NAME, instance);
^~
drivers/md/dm-vdo/vdo.c:563:2: note: ‘snprintf’ output between 2 and 66 bytes into a destination of size 16
snprintf(vdo->thread_name_prefix, sizeof(vdo->thread_name_prefix),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
"%s%u", MODULE_NAME, instance);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Suggested-by: John Garry <[email protected]>
Signed-off-by: Matthew Sakai <[email protected]>
lorelei-sakai
force-pushed
the
fix/remove-thread-name-format-warning
branch
from
6431992 to
9146ca1
Compare
github-actions
bot
added
private testing running
and removed
private testing running
labels
rhawalsh
approved these changes
Jan 15, 2025
lorelei-sakai
added a commit
that referenced
this pull request
Mar 14, 2025
…at-warning dm vdo: use a short static string for thread name prefix
lorelei-sakai
added a commit
that referenced
this pull request
May 5, 2025
…at-warning dm vdo: use a short static string for thread name prefix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges changes from PR vdo-devel/226 , which is responsive to upstream discussion.