[VDO-5642][VDO-5644] dm vdo indexer: don't read request structure after enqueuing #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
private testing running
private testing failed
and removed
private testing running
labels
The function get_volume_page_protected may place a request on a queue for another thread to process asynchronously. When this happens, the volume should not read the request from the original thread. This can not currently cause problems, due to the way request processing is handled, but it is not safe in general. Signed-off-by: Matthew Sakai <[email protected]>
lorelei-sakai
force-pushed
the
fix/pending-search-cleanup
branch
from
413ad0e to
254e480
Compare
github-actions
bot
added
private testing running
private testing failed
and removed
private testing running
labels
raeburn
approved these changes
May 7, 2025
github-actions
bot
added
private testing running
and removed
private testing running
labels
lorelei-sakai
added a commit
that referenced
this pull request
Jul 30, 2025
[VDO-5642][VDO-5644] dm vdo indexer: don't read request structure after enqueuing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function get_volume_page_protected may place a request on a queue for another thread to process asynchronously. When this happens, the volume should not read the request from the original thread. This can not currently cause problems, due to the way request processing is handled, but it is not safe in general.