fix: replace volume when the creation options change#1299
Open
erdnaxeli wants to merge 1 commit intodmacvicar:mainfrom
Open
fix: replace volume when the creation options change#1299erdnaxeli wants to merge 1 commit intodmacvicar:mainfrom
erdnaxeli wants to merge 1 commit intodmacvicar:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I changed my
libvirt_cloudinit_diskresource, which then triggered an update of the relatedlibvirt_volume. But as the code says, volumes are immutable and cannot be updated.This PR indicates to Terraform that the any change to the
createfield of a volume (which happens when the source cloudinit disk changes) should trigger a replacement instead of an update.