Skip to content

Conversation

@macadamiaz
Copy link

No description provided.

Added option "Group_Leds" to group LEDs for increased performance.
Added info about LED grouping
@dmadison
Copy link
Owner

dmadison commented Nov 4, 2024

Hi! Thanks for the PR. I like the concept but I'm not fond of the implementation. If you're willing to rewrite it to use a macro to set the group and then copy the data when the LEDs are latched rather than when the byte stream is read I'd be happy to merge it.

@macadamiaz
Copy link
Author

...If you're willing to rewrite it to use a macro to set the group and then copy the data when the LEDs are latched rather than when the byte stream is read I'd be happy to merge it.

I basically just hacked it in, as i'm not proficient at all in FastLED / Arduino / C. So what you're asking is way beyond my knowledge. If you or anyone wants to improve the implementation i'd appreciate it!

However, as it is i'm using it daily with a 232 LED Strip and getting a very high framerate / smoothness with it (which wasn't possible without grouping), so it does actually work.

@dmadison
Copy link
Owner

I've added grouping in PR #36, which has been merged and is now part of the latest release (v2.1.0). Uncomment the #define GROUPING line to enable the feature, the grouping is calculated automatically based on the data sent to the strip.

Thank you for the suggestion, and let me know if it works for you!

@dmadison dmadison closed this Jan 15, 2025
@macadamiaz
Copy link
Author

I'm now using your updated sketch with automatic grouping, it's working great, thanks! Love the way you implemented it with the automatic grouping!
I put a note on top of my fork recommending it and archived my fork, as it's no longer needed.

@dmadison
Copy link
Owner

Wonderful! I'm glad that it works for you, and thanks for following-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants