Implement UBJ and JSON models for latest XGBoost#96
Open
bradleypeabody wants to merge 1 commit intodmitryikh:masterfrom
Open
Implement UBJ and JSON models for latest XGBoost#96bradleypeabody wants to merge 1 commit intodmitryikh:masterfrom
bradleypeabody wants to merge 1 commit intodmitryikh:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since version 2.1, XGBoost now uses UBJ and JSON as its standard format. This PR adds support for that.
Key things to note:
go testto work properly. If you rungo generatethis requiresuvand runs the Python code for various relevant test cases to generate some models and expected values, which are then compared in Go. xgensemble_json_test.go uses these.