Added an ID attribute to Entry exported yaml data for importing its data #1029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary when import Entries using data that is exported from AirOne, because previous implementation doesn't write Entry-ID attribute to export data. Import processing couldn't understand which Entry is updated Entry or new created one. This commit fixed that processing by adding Entry ID to export data.
…te to ExportedEntry
hinashi
approved these changes
Dec 19, 2023
Contributor
hinashi
left a comment
hinashi
left a comment
There was a problem hiding this comment.
LGTM!
I confirmed that the export data entry ID was added.
It seems that not using the entry ID when importing. Will this be addressed in another PR?
Member
Author
Thank you very much for deeply checking this PR!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary when import Entries using data that is exported from AirOne,
because previous implementation doesn't write Entry-ID attribute to export data.
Import processing couldn't understand which Entry is updated Entry or new created one.
This commit fixed that processing by adding Entry ID to export data.