-
Notifications
You must be signed in to change notification settings - Fork 6
Fix parser to handle TypeScript types with nested quotes #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: dmmulroy <2755722+dmmulroy@users.noreply.github.com>
Co-authored-by: dmmulroy <2755722+dmmulroy@users.noreply.github.com>
|
@copilot why did you delete the type docs in db.lua, also i need you to double check all the tests and make sure they're all correctly passing |
Co-authored-by: dmmulroy <2755722+dmmulroy@users.noreply.github.com>
The type docs were accidentally deleted when I ran All tests pass: 134 tests, 0 failures. |
|
@copilot please review and audit all of our db/error tests and make sure we're correctly testing each error substitution. Correct any tests that are wrong and give me a detailed report in a comment about your findings and work |
Co-authored-by: dmmulroy <2755722+dmmulroy@users.noreply.github.com>
Completed audit of all db/error tests. Here's my detailed report: Summary:
Issues Found & Fixed (9de7db1):
Intentional Design Decisions (Not Bugs):
All substitutions that ARE used in improved_messages are correctly tested and working. |
'([^']+)'fails when types contain nested single quotes (e.g., object literal property names like'/3-ui/heading.md': { ... })(.-){0}and{1}substitutions{0},{1},{2}substitutionsOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.