Fix UnicodeDecodeError on Windows by explicitly setting UTF-8 encoding#64
Open
DRobinson4105 wants to merge 1 commit intodmort27:masterfrom
Open
Fix UnicodeDecodeError on Windows by explicitly setting UTF-8 encoding#64DRobinson4105 wants to merge 1 commit intodmort27:masterfrom
DRobinson4105 wants to merge 1 commit intodmort27:masterfrom
Conversation
Author
|
@dmort27 Please review and let me know if there is anything I need to change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves dmort27/epitran#188
This specifies
encoidng='utf-8'when openingfninFeatureTable._read_bases. On Windows, the default encoding isn't utf-8 which causes the following error:UnicodeDecodeError: 'charmap' codec can't decode byte 0x90 in position 970: character maps to <undefined>` error when running `epi = epitran.Epitran("eng-Latn")This occurs when initializing Epitran with
epi = epitran.Epitran("eng-Latn")