Skip to content

Fixed AttachEntity using wrong indexes #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed AttachEntity using wrong indexes #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions PacketWrapper/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
<dependency>
<groupId>com.comphenix.protocol</groupId>
<artifactId>ProtocolLib</artifactId>
<version>4.5.1-SNAPSHOT</version>
<version>4.7.0</version>
<scope>provided</scope>
</dependency>

Expand Down Expand Up @@ -76,6 +76,17 @@
<version>${powermock.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-gpg-plugin</artifactId>
<version>3.0.1</version>
<type>maven-plugin</type>
</dependency>
<dependency>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-source-plugin</artifactId>
<version>3.2.1</version>
</dependency>
</dependencies>

<profiles>
Expand All @@ -92,7 +103,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-source-plugin</artifactId>
<version>3.2.0</version>
<version>3.2.1</version>
<executions>
<execution>
<id>attach-sources</id>
Expand All @@ -105,7 +116,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-gpg-plugin</artifactId>
<version>1.6</version>
<version>3.0.1</version>
<executions>
<execution>
<id>sign-artifacts</id>
Expand Down Expand Up @@ -137,7 +148,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
<version>3.2.0</version>
<version>3.3.0</version>
<configuration>
<archive>
<addMavenDescriptor>false</addMavenDescriptor>
Expand Down
8 changes: 4 additions & 4 deletions PacketWrapper/src/main/java/com/comphenix/packetwrapper/WrapperPlayServerAttachEntity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public WrapperPlayServerAttachEntity(PacketContainer packet) {
* @return The current Entity ID
*/
public int getEntityID() {
return handle.getIntegers().read(0);
return handle.getIntegers().read(1);
}

/**
Expand All @@ -54,7 +54,7 @@ public int getEntityID() {
* @param value - new value.
*/
public void setEntityID(int value) {
handle.getIntegers().write(0, value);
handle.getIntegers().write(1, value);
}

/**
Expand Down Expand Up @@ -85,7 +85,7 @@ public Entity getEntity(PacketEvent event) {
* @return The current Vehicle ID
*/
public int getVehicleId() {
return handle.getIntegers().read(1);
return handle.getIntegers().read(2);
}

/**
Expand All @@ -94,6 +94,6 @@ public int getVehicleId() {
* @param value - new value.
*/
public void setVehicleId(int value) {
handle.getIntegers().write(1, value);
handle.getIntegers().write(2, value);
}
}