Skip to content

Conversation

@derklaro
Copy link
Contributor

@derklaro derklaro commented May 5, 2025

ByteBuddy update was required for Java 24 support. This consequently forced a shadow update as ByteBuddy bundles java 24 specific files (multi release jar), which weren't yet supported by the bundled asm version in the old shadow version.

Closes #3382

@NoltoxGit
Copy link

ByteBuddy update was required for Java 24 support. This consequently forced a shadow update as ByteBuddy bundles java 24 specific files (multi release jar), which weren't yet supported by the bundled asm version in the old shadow version.

Closes #3382

Hey,
Thank you for the PR! <3

But why the build failed? :c

@derklaro
Copy link
Contributor Author

derklaro commented May 5, 2025

But why the build failed? :c

Builds fails due to failing tests, but that's not related to this PR :)

@NoltoxGit
Copy link

But why the build failed? :c

Builds fails due to failing tests, but that's not related to this PR :)

Ah okay, can you provide a download link for this PR?

Copy link
Collaborator

@Ingrim4 Ingrim4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Ingrim4 Ingrim4 enabled auto-merge (squash) May 6, 2025 19:04
@dmulloy2 dmulloy2 merged commit a80762f into dmulloy2:master May 6, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ensure ProtocolLib compatibility with Java 24 and newer versions

4 participants