Setting to skip post-video ads by force #244
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
This looks really cool, thanks for the PR. I'll take a look soon |
Owner
|
If anyone wants to test this, I've pushed an image: |
boltgolt
changed the title
dmunozv04
reviewed
Feb 22, 2025
Owner
dmunozv04
left a comment
dmunozv04
left a comment
There was a problem hiding this comment.
I haven't checked, but we should make sure that a video ending in a sponsor segment would properly trigger the stop and not attempt to skip the sponsor segment, to be left with the post-video ads
| # Trigger a few frames earlier to avoid the video end event canceling the task | ||
| await asyncio.sleep(time_to - 0.1) | ||
| self.logger.info("Force stopping video, end of expected play time reached") | ||
| await asyncio.create_task(self.lounge_controller._command("stopVideo")) |
Owner
There was a problem hiding this comment.
This would be better if a new method was created on the YTLounge class
Contributor
Author
|
Good point, because of how scheduling works i don't believe that would trigger the force stop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a video is done YouTube sometimes plays +/- 30 seconds of ads after the video. This PR forcefully stops the video when its play time is over, returning to the app home screen and skipping the ads.