Ignore ReadOptions on getAll #30
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mimics the argument validator found in the Firestore client.
Owner
Author
|
@op I think this method has been removed in recent Firebase SDKs? Do you still want it? |
dmurvihill
commented
Jan 7, 2020
Owner
Author
dmurvihill
left a comment
dmurvihill
left a comment
There was a problem hiding this comment.
Circling back to this PR, I see that getAll is offered through the Admin SDK.
@op, I don't think we can silently discard a valid input; it will make users very confused. We could emit a warning on receiving a fieldMask, or throw an exception explaining that firebase-mock does not yet support ReadOptions. I'm fine with either.
| expect(snaps[2].exists).to.equal(false); | ||
| }); | ||
| }); | ||
| it('gets the value of all passed documents honoring the read options', function() { |
Owner
Author
There was a problem hiding this comment.
'Honoring' is definitely not the right word here. Did you mean 'Ignoring'?
Owner
Author
|
I am closing this PR as it is nearly two years without activity. Feel free to re-open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopening the original PR here.