Ignore trailing whitespace in cell comparison#25
Open
Iain-S wants to merge 1 commit intodnanhkhoa:masterfrom
Open
Ignore trailing whitespace in cell comparison#25Iain-S wants to merge 1 commit intodnanhkhoa:masterfrom
Iain-S wants to merge 1 commit intodnanhkhoa:masterfrom
Conversation
Owner
|
Hi @Iain-S , thank you for the PR Actually I haven't tested this yet. Do you have any problem so far with your fix? |
Author
|
Hi @dnanhkhoa , I haven't noticed any issues thus far. A minor problem is that if the user has started to add new blank lines after submission but before completion of the cell, those new lines will be deleted. I suspect that this will be only a minor annoyance but an alternative solution would be to work out why the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
If you have trailing whitespace in a Jupyter notebook cell, nb-black won't format it. For example (note the newline):
I have tested it with newlines and spaces.
Fix
It happens because
nbb_unformatted_code(which comes fromself.shell.user_ns["_i" + str(cell_id)]) is stripped of whitespace (not sure why but it is out of our control). Therefore, we should strip whitespace fromnbb_cells[i].get_text()before we compare it tonbb_unformatted_code.