Run our example notebook and verify the output#28
Open
Iain-S wants to merge 1 commit intodnanhkhoa:masterfrom
Open
Run our example notebook and verify the output#28Iain-S wants to merge 1 commit intodnanhkhoa:masterfrom
Iain-S wants to merge 1 commit intodnanhkhoa:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is entirely optional but would be nice to put on a CI server or something...
One option for testing nb-black is to have an .ipynb notebook and to run it using Selenium. After each code cell is a raw cell which shows what the code cell should look like after formatting. It would have picked up on the trailing whitespace issue and any issues with loading/unloading/reloading.
I run all the cells with a keyboard shortcut at the moment but there might be a better way.