Skip to content

Remove yapf requirement to support python > 3.6 #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
augustobottelli wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove yapf requirement to support python > 3.6 #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ def readme(file_name):
py_modules=["nb_black", "lab_black"],
zip_safe=False,
install_requires=[
"yapf >= 0.28; python_version < '3.6'",
"black >= 19.3; python_version >= '3.6'",
Copy link

@sameermanek sameermanek Jan 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the error message in #40 , it seems like we might need to change the next line as well.

Error message from #40

Expected end or semicolon (after name and no valid version specifier)
Suggested change
"black >= 19.3; python_version >= '3.6'",
"black >= 19.3",

"ipython",
],
Expand Down