Skip to content

[feat] 대표플리 존재하지 않을 때 커스터마이징 이동 버튼 추가#97

Merged
maylh merged 1 commit intodevelopfrom
fix/#96/mycd
Aug 30, 2025
Merged

[feat] 대표플리 존재하지 않을 때 커스터마이징 이동 버튼 추가#97
maylh merged 1 commit intodevelopfrom
fix/#96/mycd

Conversation

@maylh
Copy link
Collaborator

@maylh maylh commented Aug 30, 2025

🛰️ 관련 이슈


✨ 주요 변경 사항

  • 대표 플리 존재하지 않을 때 (404) 커스터마이징 이동 버튼 추가 -> 추후 디자이너 팀에 해당 UI 요청 예정

🔍 테스트 방법 / 체크리스트

  • 없음

🗯️ PR 포인트


🚀 알게된 점


📖 참고 자료 (선택)

Summary by CodeRabbit

  • 신규 기능
    • 내 대표 플레이리스트 정보를 불러오지 못할 때 전용 오류 화면을 표시합니다. 게스트 캐릭터 이미지와 작은 기본 버튼이 제공되며, 버튼을 누르면 마이페이지의 커스터마이즈로 이동합니다.
    • 오류가 없을 때는 기존 화면과 동일하게 동작합니다.
  • 스타일
    • 오류 화면 구성 요소를 중앙 정렬해 가독성과 접근성을 개선했습니다.

@maylh maylh requested a review from hansololiviakim as a code owner August 30, 2025 05:22
@gemini-code-assist
Copy link

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@coderabbitai
Copy link

coderabbitai bot commented Aug 30, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

에러 상태 처리와 내비게이션을 추가. useMyRepresentativePlaylistisError를 반환하며, 에러 시 페이지는 조기 반환하여 게스트 이미지를 보여주고 버튼으로 /mypage/customize로 이동. UI 정렬을 위한 ErrorContainer가 도입되었고 관련 컴포넌트/상수 임포트가 추가됨.

Changes

Cohort / File(s) Change Summary
MyCD 페이지 에러 플로우 추가
src/pages/mycd/index.tsx
useNavigate 도입, isError 사용한 조기 반환 에러 UI 추가(GuestCharacter, Primary Button → /mypage/customize), ErrorContainer 스타일 컴포넌트로 중앙 정렬, 관련 임포트 추가. 기존 정상 렌더 경로는 유지.
플레이리스트 훅 시그니처 확장
src/entities/playlist/model/useMyPlaylist...
useMyRepresentativePlaylist() 반환 객체에 isError: boolean 추가. 해당 값을 소비하도록 페이지가 업데이트됨.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant MyCDPage as MyCD Page
  participant Hook as useMyRepresentativePlaylist
  participant Router as navigate(/mypage/customize)

  User->>MyCDPage: 페이지 진입/렌더
  MyCDPage->>Hook: 데이터 요청
  alt 에러(isError = true)
    Hook-->>MyCDPage: { isError: true, data: null }
    MyCDPage-->>User: 게스트 이미지 + 커스터마이즈 버튼 표시
    User->>MyCDPage: 버튼 클릭
    MyCDPage->>Router: navigate("/mypage/customize")
  else 정상
    Hook-->>MyCDPage: { isError: false, data }
    MyCDPage-->>User: 기존 콘텐츠 렌더
  end
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested labels

HIGH

Poem

밤하늘 릴스에 별이 빈칸처럼 떠,
에러라니? 깡총~ 버튼 타고 길을 터!
게스트 그림에 살짝 웃음 번져서,
커스터마이즈로 점프! 길을 다시 써.
코드엔 새 갈래, 토끼는 폴짝퍼! 🐇✨


📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 977a9b4 and 8ed2879.

📒 Files selected for processing (1)
  • src/pages/mycd/index.tsx (4 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/#96/mycd

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@maylh maylh changed the title feat: 대표플리 존 재하지 않을 때 커스터마이징 이동 버튼 추가 (no-issue) feat: 대표플리 존재하지 않을 때 커스터마이징 이동 버튼 추가 Aug 30, 2025
@github-actions
Copy link

🎵 Storybook Link 🎵
🔗 https://689dbb45f8d09aea7832eeb1-trwhnjmwyu.chromatic.com/

@maylh maylh merged commit 9d7041d into develop Aug 30, 2025
3 of 4 checks passed
@maylh maylh deleted the fix/#96/mycd branch August 30, 2025 05:23
@hansololiviakim hansololiviakim added the HIGH 빠르게 처리해야 하는 높은 우선순위 label Aug 30, 2025
@maylh maylh changed the title feat: 대표플리 존재하지 않을 때 커스터마이징 이동 버튼 추가 [feat] 대표플리 존재하지 않을 때 커스터마이징 이동 버튼 추가 Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HIGH 빠르게 처리해야 하는 높은 우선순위

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[fix] 대표플리 없을 때

2 participants