Open
Conversation
dnnr
pushed a commit
that referenced
this pull request
Jan 6, 2023
The frame attributes of FrameLeaf and FrameSplit are now writable and allow to adjust the frame locally. As usual, the test cases consume more lines than the actual source code accomplishing this change. In the source code, the getTag() function seemed to be unused. Unfortunately, I had to remove the 'const' qualifier from getFraction() because otherwise the DynAttribute_ constructor failed to match. This is another step towards a full implementation of frame objects (#2) and this fixes #7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.