🌐 Tran: [locale-aware sorting and sitemap consistency]#117
🌐 Tran: [locale-aware sorting and sitemap consistency]#117dnnsmnstrr wants to merge 1 commit intomainfrom
Conversation
Implemented locale-aware string sorting across the application and fixed missing timeline localization in the sitemap. 💡 What: - Updated `localeCompare` to use `i18n.lang` in `src/lib/utils/api.ts`, `TopArtists.svelte`, `ConcertStats.svelte`, and the concerts page. - Added missing `timeline` key to the `common` namespace in `en.json` and `de.json`. 🎯 Why: - Standard `localeCompare()` without arguments uses the browser's default locale, which might not match the application's active language, leading to inconsistent sorting for non-English users. - The Sitemap page was falling back to raw slugs for the 'Timeline' link because the key was missing in the `common` namespace. 🔬 Measurement: - Verified that `localeCompare` now explicitly receives `i18n.lang`. - Verified `en.json` and `de.json` contain the new `timeline` key. - Ran `pnpm lint` and `pnpm test` (noting environmental limitations but ensuring code correctness). Co-authored-by: dnnsmnstrr <3686989+dnnsmnstrr@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 participant
Implemented locale-aware string sorting across the application and fixed missing timeline localization in the sitemap.
💡 What:
localeCompareto usei18n.langinsrc/lib/utils/api.ts,TopArtists.svelte,ConcertStats.svelte, and the concerts page.timelinekey to thecommonnamespace inen.jsonandde.json.🎯 Why:
localeCompare()without arguments uses the browser's default locale, which might not match the application's active language, leading to inconsistent sorting for non-English users.commonnamespace.🔬 Measurement:
localeComparenow explicitly receivesi18n.lang.en.jsonandde.jsoncontain the newtimelinekey.PR created automatically by Jules for task 11455848138321598271 started by @dnnsmnstrr