Skip to content

BreadCrumb skin object to render semantic, accessible breadcrumb markup #6898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitchelsellers merged 11 commits into from
Jan 26, 2026
Merged

BreadCrumb skin object to render semantic, accessible breadcrumb markup #6898

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a30da9c
Refactor breadcrumb control for semantic HTML
uzmannazari Jan 8, 2026
27f4faa
Refactor BreadCrumb class for improved readability
uzmannazari Jan 8, 2026
0f75c20
Refactor base styles in _type.scss for default breadcrumb styles
uzmannazari Jan 8, 2026
bd754b8
Refactor breadcrumb control structure
uzmannazari Jan 8, 2026
0a90355
Refactor BreadCrumb class for improved functionality
uzmannazari Jan 8, 2026
c289878
added localized resource file for breadcrumb on markup mode
uzmannazari Jan 8, 2026
8fcb9d0
Add doc comment back
bdukes Jan 12, 2026
8c8968c
Update BreadCrumb.ascx.cs
uzmannazari Jan 23, 2026
a3c4df7
Merge branch 'develop' into patch-6
uzmannazari Jan 23, 2026
91fc3b3
Use raw strings for HTML
bdukes Jan 26, 2026
4890b3a
Move breadcrumb CSS
bdukes Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion DNN Platform/Dnn.ClientSide/src/styles/default-css/10.0.0/base/_type.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,4 +44,15 @@ p a, p a:visited {
ul, ol{
padding-inline-start: 1.5rem;
list-style-position: outside;
}
}
nav.dnnBreadcrumb ol {
list-style: none;
display: flex;
align-items: center;
gap: 0.5rem;
}

nav.dnnBreadcrumb ol li span {
margin-inline-start: 0.5rem;
display: inline-block;
}
45 changes: 45 additions & 0 deletions DNN Platform/Website/admin/Skins/App_LocalResources/BreadCrumb.ascx.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
<?xml version="1.0" encoding="UTF-8" ?>
<root>
<xsd:schema id="root" xmlns="" xmlns:xsd="https://www.w3.org/2001/XMLSchema" xmlns:msdata="urn:schemas-microsoft-com:xml-msdata">
<xsd:element name="root" msdata:IsDataSet="true">
<xsd:complexType>
<xsd:choice maxOccurs="unbounded">
<xsd:element name="data">
<xsd:complexType>
<xsd:sequence>
<xsd:element name="value" type="xsd:string" minOccurs="0" msdata:Ordinal="1" />
<xsd:element name="comment" type="xsd:string" minOccurs="0" msdata:Ordinal="2" />
</xsd:sequence>
<xsd:attribute name="name" type="xsd:string" />
<xsd:attribute name="type" type="xsd:string" />
<xsd:attribute name="mimetype" type="xsd:string" />
</xsd:complexType>
</xsd:element>
<xsd:element name="resheader">
<xsd:complexType>
<xsd:sequence>
<xsd:element name="value" type="xsd:string" minOccurs="0" msdata:Ordinal="1" />
</xsd:sequence>
<xsd:attribute name="name" type="xsd:string" use="required" />
</xsd:complexType>
</xsd:element>
</xsd:choice>
</xsd:complexType>
</xsd:element>
</xsd:schema>
<resheader name="ResMimeType">
<value>text/microsoft-resx</value>
</resheader>
<resheader name="Version">
<value>1.0.0.0</value>
</resheader>
<resheader name="Reader">
<value>System.Resources.ResXResourceReader, System.Windows.Forms, Version=1.0.3300.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
</resheader>
<resheader name="Writer">
<value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=1.0.3300.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
</resheader>
<data name="BreadCrumbAriaLabel.Text">
<value>Breadcrumb</value>
</data>
</root>
Loading