Add ESLint for JavaScript and Vue linting #920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add ESLint 9.x with flat config format - Add eslint-plugin-vue for Vue 3 component linting - Add lint and lint:fix npm scripts - Rename webpack.config.js to webpack.config.cjs for ES modules compatibility - Fix minor linting issues in existing code: - Use v-show instead of v-if with v-for in tabs.vue - Prefix unused catch variable with underscore
There was a problem hiding this comment.
Pull request overview
This PR adds ESLint to the project to enforce code quality standards for JavaScript and Vue files. The changes establish a linting infrastructure with automated checks in CI, configured to work with the project's ES module setup while maintaining compatibility with CommonJS files like the webpack configuration.
Changes:
- Added ESLint v9.18.0 with Vue 3 plugin support and recommended rule configurations
- Fixed existing linting issues in Vue components and JavaScript utility files
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Added ESLint and related dependency entries |
| package.json | Added module type and ESLint dependencies with lint scripts |
| eslint.config.js | New flat config with JavaScript and Vue 3 rules, environment-specific globals |
| src/components/tabs.vue | Changed v-if to v-show to comply with Vue best practices |
| .github/scripts/validate-fixtures-json.js | Prefixed unused catch variable with underscore and fixed trailing whitespace |
| .github/workflows/ci.yml | Added lint job to CI workflow |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Use eslint.config.mjs instead of adding type:module to package.json - Keep webpack.config.js and validate-fixtures-json.js as regular .js files - No changes needed to project module system
- Add semi and curly rules to ESLint config - Remove Vue-specific rule overrides - Fix code to comply with new linting rules - Use empty catch block syntax (ES2019)
dallasread
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds ESLint to the project for linting JavaScript and Vue files. We were running an old version of ESLint that was removed in #909
Changes
New Dependencies
eslintv9.18.0 - Core ESLint package@eslint/js- ESLint recommended JavaScript ruleseslint-plugin-vuev9.32.0 - Vue 3 component lintingglobalsv15.14.0 - Environment globals definitionsNew Files
eslint.config.js- ESLint flat config with:dist/,output/,node_modules/,tmp/Modified Files
package.json:"type": "module"for ES modules supportlintandlint:fixscriptswebpack.config.js→webpack.config.cjs- Renamed for CommonJS compatibilitysrc/components/tabs.vue- Changedv-iftov-showto fix Vue best practice warning.github/scripts/validate-fixtures-json.js- Prefixed unused catch variable with underscoreUsage
Testing
yarn lintpasses with no errorsyarn buildworks correctly with renamed webpack config