Skip to content

Conversation

@weppos
Copy link
Member

@weppos weppos commented Jan 13, 2026

Summary

Removes the deprecated GetWhoisPrivacy and RenewWhoisPrivacy endpoints and all associated code.

See dnsimple/dnsimple-developer#919

@weppos weppos self-assigned this Jan 13, 2026
@weppos weppos added the enhancement New feature, enhancement or code changes, not related to defects label Jan 13, 2026
@weppos weppos requested a review from DXTimer January 13, 2026 16:46
@weppos weppos requested a review from NelsonVides January 14, 2026 13:01
Copy link

@NelsonVides NelsonVides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the same that we saw at the elixir sdk, looks good to me 👌🏽

Btw, I also noticed https://github.com/dnsimple/dnsimple-go/blob/main/.github/workflows/sync-test-fixtures.yml, which will fetch again the fixtures we're just removing here. Have we deleted them from upstream?

@weppos
Copy link
Member Author

weppos commented Jan 14, 2026

Btw, I also noticed https://github.com/dnsimple/dnsimple-go/blob/main/.github/workflows/sync-test-fixtures.yml, which will fetch again the fixtures we're just removing here. Have we deleted them from upstream?

Not yet. It will happen once we merge dnsimple/dnsimple-developer#919

That workflow is, AFAIK, run manually so it won't be triggered unless we manually do it. And in any case, once the fixtures are removed upstream, we'll also sync any deletion.

@weppos weppos merged commit 299d5af into main Jan 14, 2026
4 checks passed
@weppos weppos deleted the deprecation-renewWhoisPrivacy branch January 14, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, enhancement or code changes, not related to defects

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants