Skip to content

Fix dnsimple_ds_record incorrect attribute name key_tag #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weppos merged 1 commit into from
Jan 8, 2026
Merged

Fix dnsimple_ds_record incorrect attribute name key_tag #322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## unreleased

BUG FIXES:

- resource/`dnsimple_ds_record`: Fix attribute name from `keytag` to `key_tag` to match documentation and Terraform naming conventions (#321)

## 2.0.0 - 2025-12-15

BREAKING CHANGES:
Expand Down
4 changes: 2 additions & 2 deletions internal/framework/resources/domain_ds_record_resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ type DsRecordResourceModel struct {
Algorithm types.String `tfsdk:"algorithm"`
Digest types.String `tfsdk:"digest"`
DigestType types.String `tfsdk:"digest_type"`
Keytag types.String `tfsdk:"keytag"`
Keytag types.String `tfsdk:"key_tag"`
PublicKey types.String `tfsdk:"public_key"`
CreatedAt types.String `tfsdk:"created_at"`
UpdatedAt types.String `tfsdk:"updated_at"`
Expand Down Expand Up @@ -82,7 +82,7 @@ func (r *DsRecordResource) Schema(_ context.Context, _ resource.SchemaRequest, r
stringplanmodifier.RequiresReplace(),
},
},
"keytag": schema.StringAttribute{
"key_tag": schema.StringAttribute{
Optional: true,
PlanModifiers: []planmodifier.String{
stringplanmodifier.RequiresReplace(),
Expand Down
4 changes: 2 additions & 2 deletions internal/framework/resources/domain_ds_record_resource_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ func TestAccDomainDsRecordResource(t *testing.T) {
resource.TestCheckResourceAttr(resourceName, "algorithm", "8"),
resource.TestCheckResourceAttr(resourceName, "digest", "C3D49CB83734B22CF3EF9A193B94302FA3BB68013E3E149786D40CDC1BBACD93"),
resource.TestCheckResourceAttr(resourceName, "digest_type", "2"),
resource.TestCheckResourceAttr(resourceName, "keytag", "51301"),
resource.TestCheckResourceAttr(resourceName, "key_tag", "51301"),
resource.TestCheckResourceAttr(resourceName, "public_key", "AwEAAd4gdAYAeCnAsYYStm/eWd6uRn5XvT14D9DDM9TbmCvLKCuRA6WYz7suLAziJ5hvk2I7aTOVK8Wd1fDmVxHXGg0Jd6P2+GQpg7AGghD+oLeg0I7AesSIKO3o1ffr58x6iIsxVZ+fcC7G6vdr/d8oIJ/SZdAvghQnCNmCm49HLoN6bWJWNJIXzmxFrptvfgfB4B+PVzbquZrJ0W10KrD394U="),
resource.TestCheckResourceAttrSet(resourceName, "created_at"),
resource.TestCheckResourceAttrSet(resourceName, "updated_at"),
Expand Down Expand Up @@ -94,7 +94,7 @@ resource "dnsimple_ds_record" "test" {
algorithm = "8"
digest = "C3D49CB83734B22CF3EF9A193B94302FA3BB68013E3E149786D40CDC1BBACD93"
digest_type = "2"
keytag = "51301"
key_tag = "51301"
public_key = "AwEAAd4gdAYAeCnAsYYStm/eWd6uRn5XvT14D9DDM9TbmCvLKCuRA6WYz7suLAziJ5hvk2I7aTOVK8Wd1fDmVxHXGg0Jd6P2+GQpg7AGghD+oLeg0I7AesSIKO3o1ffr58x6iIsxVZ+fcC7G6vdr/d8oIJ/SZdAvghQnCNmCm49HLoN6bWJWNJIXzmxFrptvfgfB4B+PVzbquZrJ0W10KrD394U="
}`, domainName)
}