Be less verbose in dnstap loop

[eest]

Keep counters instead of potentially spamming logs.

Summary by CodeRabbit

• Chores
  • Added three new per-instance monitoring counters to improve visibility into DNS processing issues (parsing errors, empty question sections, and invalid question names). Error handling now increments these metrics instead of logging, enabling better metrics-driven alerting and debugging.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

The change replaces error logging with Prometheus counter increments in DNS dnstap parsing paths, adds three per-instance counters for parse errors, empty question sections, and invalid question names, and removes an unused loop index in question iteration.

Changes

Cohort / File(s)	Summary
Prometheus instrumentation & parsing logic pkg/runner/runner.go	Added three per-instance Prometheus counters (promDNSParseError, promEmptyQuestionSection, promInvalidQuestionName) and their initialization in newDnstapMinimiser. Replaced error logs with counter increments for parse failures, empty question sections, and invalid question names. Switched question loop from for i, question := range to for _, question := range (removed unused index).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 I bounced past logs and found a score,
Counters counting knocks upon the door,
Parse slips, blank queries, names gone stray,
Prometheus takes note as I hop away,
Metrics hum — I twitch my whiskers, hooray! 🎉

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Be less verbose in dnstap loop' accurately captures the main objective of reducing log verbosity in the dnstap processing loop by replacing error logs with Prometheus counters.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@pkg/runner/runner.go`:
- Around line 1992-1996: The inner loop over msg.Question increments
edm.promInvalidQuestionName but uses a plain continue which only skips to the
next question and not the outer minimiserLoop, so messages with any invalid
question still get processed; change the control flow to skip the entire message
when an invalid question is found — either break out to a labeled continue for
minimiserLoop or set a local flag (e.g., invalidQuestion := true) when
edm.promInvalidQuestionName.Inc() is called and after the for _, question :=
range msg.Question loop check that flag and continue the outer loop
(minimiserLoop) to skip processing msg; update references to msg.Question and
edm.promInvalidQuestionName accordingly.

[zluudg]

LGTM